Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus to input elements on login page #1792

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Add focus to input elements on login page #1792

merged 2 commits into from
Mar 11, 2021

Conversation

JammingBen
Copy link
Contributor

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@owncloud owncloud deleted a comment from update-docs bot Mar 10, 2021
@JammingBen JammingBen requested a review from kulmann March 10, 2021 15:23
kulmann
kulmann requested changes Mar 10, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make generate within the idp dir once, so that the login page gets compiled into the embed.go file of the idp service. That needs to be committed as well.

Other than that: LGTM 👍 Choosing white as focus color makes sense. Color contrast to the background is 16.58:1, which is probably the best we can get 😁

@JammingBen
Copy link
Contributor Author

Please run make generate within the idp dir once, so that the login page gets compiled into the embed.go file of the idp service. That needs to be committed as well.

Alright 👍

How do you keep it with rebasing in OCIS repos? "Keep it real" or ideally one commit per PR?

@JammingBen JammingBen requested a review from kulmann March 10, 2021 16:28
kulmann
kulmann approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🚀

@kulmann
Copy link
Member

kulmann commented Mar 10, 2021

Please run make generate within the idp dir once, so that the login page gets compiled into the embed.go file of the idp service. That needs to be committed as well.

Alright 👍

How do you keep it with rebasing in OCIS repos? "Keep it real" or ideally one commit per PR?

Keep all the commits. ;-) Most of us love to have a history and to be able to bisect with useful, small result sets. ;-)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen
Copy link
Contributor Author

Keep all the commits. ;-) Most of us love to have a history and to be able to bisect with useful, small result sets. ;-)

Yeees, nice! :)

@JammingBen JammingBen merged commit 8f9e1dd into master Mar 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/web-4322 branch March 11, 2021 07:37
ownclouders pushed a commit that referenced this pull request Mar 11, 2021
@JammingBen
commit 8f9e1dd
52a89eb 
Merge: 6f9df98 cdeda5c
Author: Jannik Stehle <[email protected]>
Date:   Thu Mar 11 08:37:20 2021 +0100

    Merge pull request #1792 from owncloud/issues/web-4322

    Add focus to input elements on login page
@fschade fschade mentioned this pull request Mar 29, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit #1 – Login Page – Focus styles on text input missing
2 participants
@JammingBen @kulmann